Skip to content

SeaDatabricksClient: Add Metadata Commands #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 105 commits into
base: sea-migration
Choose a base branch
from
Open

SeaDatabricksClient: Add Metadata Commands #593

wants to merge 105 commits into from
+685 −58

Conversation

varun-edachali-dbx
Copy link
Collaborator

@varun-edachali-dbx varun-edachali-dbx commented Jun 11, 2025 •
edited
Loading

What type of PR is this?

  • Feature

Description

Add metadata command implementations for the SeaDatabricksClient (execution phase) - get_catalogs, get_schemas, get_tables and get_columns.

How is this tested?

The coverage of the functionality added (by test_filters.py and the new tests in test_sea_backend.py) are as below:

Module Statements Missing Coverage Notes
filters.py 33 1 97% Line 21: from databricks.sql.result_set import ResultSet, SeaResultSet (TYPE_CHECKING import)
sea/backend.py (metadata methods) 121 0 100% Fully covered

Related Tickets & Documents

https://docs.google.com/document/d/1Y-eXLhNqqhrMVGnOlG8sdFrCxBTN1GdQvuKG4IfHmo0/edit?usp=sharing

@varun-edachali-dbx
[squash from exec-sea] bring over execution phase changes
138c2ae 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
remove excess test
3e3ab94 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
add docstring
4a78165 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
remvoe exec func in sea backend
0dac4aa 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
remove excess files
1b794c7 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
remove excess models
da5a6fe 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
remove excess sea backend tests
686ade4 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
cleanup
31e6c83 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
re-introduce get_schema_desc
69ea238 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
remove SeaResultSet
66d7517 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
clean imports and attributes
71feef9 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
pass CommandId to ExecResp
ae9862f 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
remove changes in types
d8aa69e 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
add back essential types (ExecResponse, from_sea_state)
db139bc 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
fix fetch types
b977b12 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
excess imports
da615c0 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
reduce diff by maintaining logs
0da04a6 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
fix int test types
ea9d456 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
[squashed from exec-sea] init execution func
8985c62 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
remove irrelevant changes
d9bcdbe 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
remove ResultSetFilter functionality
ee9fa1c 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
remove more irrelevant changes
24c6152 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
remove more irrelevant changes
67fd101 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
even more irrelevant changes
271fcaf 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
remove sea response as init option
bf26ea3 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
exec test example scripts
ed7cf91 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
formatting (black)
dae15e3 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
[squashed from sea-exec] merge sea stuffs
db5bbea 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
remove excess changes
d5d3699 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
remove excess removed docstring
6137a3d 
Signed-off-by: varun-edachali-dbx <[email protected]>
@databricks databricks deleted a comment from github-actions bot Jun 18, 2025
@databricks databricks deleted a comment from github-actions bot Jun 18, 2025
@varun-edachali-dbx varun-edachali-dbx changed the base branch from exec-phase-sea to sea-migration June 18, 2025 07:55
@github-actions GitHub Actions
Copy link

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@databricks databricks deleted a comment from github-actions bot Jun 18, 2025
@varun-edachali-dbx varun-edachali-dbx marked this pull request as ready for review June 18, 2025 08:29
@databricks databricks deleted a comment from github-actions bot Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deeksha-db deeksha-db Awaiting requested review from deeksha-db deeksha-db is a code owner

@samikshya-db samikshya-db Awaiting requested review from samikshya-db samikshya-db is a code owner

@jprakash-db jprakash-db Awaiting requested review from jprakash-db jprakash-db is a code owner

@jackyhu-db jackyhu-db Awaiting requested review from jackyhu-db jackyhu-db is a code owner

@madhav-db madhav-db Awaiting requested review from madhav-db madhav-db is a code owner

@gopalldb gopalldb Awaiting requested review from gopalldb gopalldb is a code owner

@jayantsing-db jayantsing-db Awaiting requested review from jayantsing-db jayantsing-db is a code owner

@vikrantpuppala vikrantpuppala Awaiting requested review from vikrantpuppala vikrantpuppala is a code owner

@shivam2680 shivam2680 Awaiting requested review from shivam2680 shivam2680 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@varun-edachali-dbx